-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load()
in 1.0.0 not rebuilding necessary down-sampling cum_table
#1180
Comments
Thanks. are you working on a fix or should I submit a pr? |
@tmylk what is the explanation for this bug making it past the unit tests? |
Not currently working on this; just wanted to make sure there was an issue that could be triaged/assigned. Not sure the understanding above is fully correct - the code looks broken, but I would have expected any save/loadthat involves a (default) negative-sampling model to have triggered the error, so aspects of the problem as-reported are still unclear. |
To be clearer: any [save, load, train] should trigger the error - perhaps no existing tests try training after load? Adding either a |
There is no unit test that covers training after load in either doc2vec or word2vec. Adding them now. |
See: https://groups.google.com/d/msg/gensim/F9SLBpik4Yg/Jz7BhRH_DQAJ
The test in Word2Vec
load()
is only chcking forindex2word
in its old location, thus a necessary structure for continued training isn't rebuilt.Surprised no existing save/load tests catch this as the re-build should even be necessary for a save/load within the same latest gensim version.
The text was updated successfully, but these errors were encountered: