Optimize performance of Author-Topic model (#2978)

* take out common part of expression in ATModel * Update atmodel.py * Update atmodel.py * Update CHANGELOG.md Co-authored-by: Michael Penkov <m@penkov.dev>
piskvorky · May 12, 2021 · 52281eb · 52281eb
1 parent 69b8cb5
commit 52281eb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,9 @@ Changes
 - [#3115](https://github.com/RaRe-Technologies/gensim/pull/3115): Make LSI dispatcher CLI param for number of jobs optional, by [@robguinness](https://github.com/robguinness))
 - Update link to Hoffman paper (online VB LDA) (PR [#3133](https://github.com/RaRe-Technologies/gensim/pull/3133), [@jonaschn](https://github.com/jonaschn))
 - fix bug when loading saved Phrases model (PR [#3116](https://github.com/RaRe-Technologies/gensim/pull/3116), [@aloknayak29](https://github.com/aloknayak29))
+- Optimize performance of Author-Topic model (PR [#2978](https://github.com/RaRe-Technologies/gensim/pull/2978), [@horpto](https://github.com/horpto))
+
+### :+1: Improvements
 
 ### Documentation
 

diff --git a/gensim/models/atmodel.py b/gensim/models/atmodel.py
@@ -498,9 +498,12 @@ def inference(self, chunk, author2doc, doc2author, rhot, collect_sstats=False, c
 
                 # Update gamma.
                 # phi is computed implicitly below,
+                dot = np.dot(cts / phinorm, expElogbetad.T)
                 for ai, a in enumerate(authors_d):
-                    tilde_gamma[ai, :] = self.alpha + len(self.author2doc[self.id2author[a]])\
-                        * expElogthetad[ai, :] * np.dot(cts / phinorm, expElogbetad.T)
+                    tilde_gamma[ai, :] = (
+                        self.alpha
+                        + len(self.author2doc[self.id2author[a]]) * expElogthetad[ai, :] * dot
+                    )
 
                 # Update gamma.
                 # Interpolation between document d's "local" gamma (tilde_gamma),