Added default value to maximumUsage in Scheduler

[BenzeneAlcohol]

Added default value to maximumUsage

Fixes: #497

Something to do:

What if maximumUsage > os.availableParallelism() ?

[BenzeneAlcohol]

Also, os.availableParallelism() is available only on node versions > v18.14.0

[metcoder95]

Although we do not have the matrix anymore, we still officially support v16; so feel free to do a check over the Node version running and only get the value if the os.availableParallelism is available.

[BenzeneAlcohol]

So in case the version is less than 16, what should this default to? There is os.cpus() that almost does the same, do we default to the length of that, or some other number?

[metcoder95]

Feel free to use https://www.npmjs.com/package/process-warning instead, has better ergonomics for these kind of situations

[BenzeneAlcohol]

Sure.

[metcoder95]

Let's also add a note in the documentation about this 👍

[metcoder95]

Oh, my bad, I didn't notice you were working on top of my PR; let's aim first for the current version and later we can port it to the PR 👍

So, for the current version, we should seek to use it whenever we want to get the max amount of threads if this option has not been passed through the constructor; so we can change it here:

piscina/src/index.ts

Line 33 in a7042ea

const cpuCount : number = (() => {

If the function is not available because it's being run under Node v16, let's keep the cpus.length.

The maximumUsage, is calculated based on the concurrentTasksPerWorker, which should be kept as default to the same number as os.availableParallelism() or cpu.length.

The warning, let's keep it but just port it to how is used within the current version of Piscina 👍

[BenzeneAlcohol]

Oh, my bad, I didn't notice you were working on top of my PR; let's aim first for the current version and later we can port it to the PR 👍

So, for the current version, we should seek to use it whenever we want to get the max amount of threads if this option has not been passed through the constructor; so we can change it here:

piscina/src/index.ts

Line 33 in a7042ea

const cpuCount : number = (() => {

If the function is not available because it's being run under Node v16, let's keep the cpus.length.

The maximumUsage, is calculated based on the concurrentTasksPerWorker, which should be kept as default to the same number as os.availableParallelism() or cpu.length.

The warning, let's keep it but just port it to how is used within the current version of Piscina 👍

Right, got it!

[github-actions]

This issue has been marked as stale because it has been opened 45 days without activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.