Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add communication from worker to main thread #213

Merged
merged 2 commits into from
May 2, 2022
Merged

Add communication from worker to main thread #213

merged 2 commits into from
May 2, 2022

Conversation

Elyahou
Copy link
Contributor

@Elyahou Elyahou commented Mar 27, 2022

Fix: #212

@Elyahou Elyahou mentioned this pull request Mar 27, 2022
Closed
jasnell
jasnell approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd like to get @addaleax's opinion also

@Elyahou
Copy link
Contributor Author

Elyahou commented May 2, 2022

@jasnell @addaleax Any news ?

@jasnell jasnell merged commit bb37c26 into piscinajs:current May 2, 2022
@alolis alolis mentioned this pull request Oct 11, 2022
Closed
@alolis
Copy link

alolis commented Oct 12, 2022 •
edited
Loading

@Elyahou, can you please provide instructions on how did you add "current" branch of piscina to your project in order to use your merged PR?

I am mostly interested with the steps AFTER the npm/yarn add https://github.com/piscinajs/piscina.git#current part ;)

@metcoder95
Copy link
Member

metcoder95 commented Oct 12, 2022 •
edited
Loading

You can take a look at npm official docs here.
Recommend you stay tuned for possible upgrades/merges against the main branch as is possible that unexpected changes can break your app between installations 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workers to main thread communication
4 participants
@Elyahou @alolis @metcoder95 @jasnell