feat: expose maxThreads and minThreads out of Piscina instance
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
changed the title
maxThreads and minThreads out of Piscina instance
jasnell
previously approved these changes
Sep 11, 2021
|
I'm not sure from where the error is popping up 🤔 |
|
Not sure. I should have time to take a look tomorrow! |
|
@metcoder95 ... sorry this took a while for me to get back to. Can you rebase this on the |
metcoder95
force-pushed
the
feat/expose_cpu_info
branch
from
bbb800c to
ac43526
Compare
|
Of course, no worries at all. Done 👍 |
jasnell
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147
The PR exposes the
maxThreads, andminThreadscalculated or supplied by theoptionsobject.Adds some tests for covering the changes.
Hope I understood the issue correctly, if not, happy to go in another way :)