fix API:subPanel.initial/fixedHeight

[NiklasGollenstede]

Following #2865 I now tested the subPanel.initial/fixedHeight integration options, and the height was off.
Actually removing a bit of code fixes that. And it also makes more sense now. the mHeight eventually ends up being assigned directly to the subPanel <iframe>, which is what the height should be for.

[piroor]

Hmm, I intentionally added the height of the sub panel, because:

• It can be changed by some reasons - system font size, user styles, and more.
• On the other hand, the height of sub panel contents can be controlled completely by the sub panel provider author.

If TST doesn't add the height of the header, sub panel contents may be cut off accidentally. How do you think about this point?

[NiklasGollenstede]

What I changed is the computation of mHeight. Besides being saved, restored and capped, it is (I think only) used in these assignments:

const appliedHeight = Math.min(window.innerHeight * 0.66, mHeight);
mContainer.style.height = `${appliedHeight + headerSize}px`;
mSubPanel.style.height = `${appliedHeight}px`;
mTabBarContainer.style.bottom = `${appliedHeight + headerSize}px`;

Where mSubPanel is the iframe whose height I would be expecting to set with this API.
The mContainer does indeed need the additional headerSize`. But I think you were adding it twice before.

And I can tell you that it works now 🤷 (for me, at least)

[piroor]

Oops, sorry I completely misunderstood what I did... You are right, I didn't need to add the header size!

[NiklasGollenstede]

Cooli!

By the way, (and not that I am urging you) but do you have an idea when you will publish this change?

[piroor]

I think #2864 is a blocker for the new release, because some changes I already did can break accessibility and need to be tested.

[NiklasGollenstede]

Ok. Thanks for the info!