Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add translation limit to wheel and prismatic joint #250

Draft
wants to merge 1 commit into
base: v2-dev
Choose a base branch
from

Conversation

zOadT
Copy link
Collaborator

@zOadT zOadT commented Aug 5, 2023

Commits:

  • ad2c44ce802cf04e1b16c41e8bc2c5bcecc7283f

Sadly there is also an error currently in this implementation

@@ -584,6 +672,48 @@ export class WheelJoint extends Joint {
wB += iB * impulse;
}

if (this.m_enableLimit) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the error: In the car example the impulses in this block get way too large

@zOadT zOadT changed the base branch from master to v2-dev August 12, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant