cherry-pick: Add container set fixes to v3.4.8 (#22) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #TODO Please do not open a pull request until you have checked ALL of these: * [ ] Create the PR as draft . * [ ] Run `make pre-commit -B` to fix codegen and lint problems. * [ ] Sign-off your commits (otherwise the DCO check will fail). * [ ] Use [a conventional commit message](https://www.conventionalcommits.org/en/v1.0.0/) (otherwise the commit message check will fail). * [ ] "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue). * [ ] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots. * [ ] Github checks are green. * [ ] Once required tests have passed, mark your PR "Ready for review". If changes were requested, and you've made them, dismiss the review to get it reviewed again. --------- Signed-off-by: isubasinghe <isitha@pipekit.io>
|
@isubasinghe - I had to make some slight changes to deal with a conflict. Could you take a look? |
JPZ13
changed the title
isubasinghe
approved these changes
Jun 6, 2023
Ensures that a DAG is marked as failed always when shutdown strategy is enabled. --------- Signed-off-by: isubasinghe <isitha@pipekit.io> Co-authored-by: Alan Clucas <alan@clucas.org>
…for LadyBug. (#10) Need to properly fix this later, looks to be some kinda race condition where sometimes Name is defined and sometimes it is not. Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
JPZ13
changed the title
|
@tico24 - when you're feeling better, can you cut a release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks @isubasinghe's commits related to container sets against a v3.4.8 install. After validating with our affected customer, we should look to contribute these into the upstream