Add deploy target #5378
Add deploy target #5378
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5378 +/- ##
==========================================
+ Coverage 25.57% 25.80% +0.22%
==========================================
Files 447 445 -2
Lines 48004 47859 -145
==========================================
+ Hits 12279 12351 +72
+ Misses 34765 34545 -220
- Partials 960 963 +3 ☔ View full report in Codecov by Sentry. |
pkg/model/application.proto
Outdated
|
|
||
| repeated string deploy_targets = 16; |
There was a problem hiding this comment.
How about adding comments and a validation?
The validation may be like min_len = 1
There was a problem hiding this comment.
This should not have validation, or application which created by pipedv0 will be invalided 👀
There was a problem hiding this comment.
Also, could you add comment to explain what does this field do or be used for @ffjlabo
There was a problem hiding this comment.
Forgot to add comment 🙏 will do it.
There was a problem hiding this comment.
@Warashi @khanhtc1202 fied f31a246
|
@ffjlabo You may need to update dummyApplication to pass the web test 👀 |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
|
@khanhtc1202 fixed for lint/web 3bc49da |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
|
@khanhtc1202 @Warashi Sorry for my sloppy fixes 🙏 Fixed and passed the CI |
What this PR does:
Added deployTarget to the model and piped config to use them on the pipedv1.
Why we need it:
Which issue(s) this PR fixes:
Part of #5252
Does this PR introduce a user-facing change?: