Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin config from plugin deployment api #5377

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does:

Remove plugin config from plugin deployment APIs.

Why we need it:

We can pass the plugin config to the plugin once the piped starts the plugins; we don't need to pass the plugin config each time the piped calls the plugins' interfaces.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Let's merge after CI has passed

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
BTW, do we have to add an RPC like InitializePlugin?

@khanhtc1202 khanhtc1202 merged commit 55a7cb1 into master Dec 2, 2024
16 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-plugin-config branch December 2, 2024 06:42
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.81%. Comparing base (eb9770c) to head (d7fe9dc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5377      +/-   ##
==========================================
- Coverage   25.82%   25.81%   -0.01%     
==========================================
  Files         445      445              
  Lines       47861    47859       -2     
==========================================
- Hits        12359    12355       -4     
- Misses      34539    34542       +3     
+ Partials      963      962       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khanhtc1202
Copy link
Member Author

Thanks. BTW, do we have to add an RPC like InitializePlugin?

I will think about this while implementing the piped start plugins logic 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants