Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry logic for RunBinary function #5361

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Nov 22, 2024

What this PR does:

This PR implements the retry logic for the RunBinary function.
This retry occurs when the cmd.Start fails, so it's not handling unexpected exits of the commands.

Why we need it:

It's better to retry to avoid unexpected failure.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.43%. Comparing base (fda760d) to head (c13e5c9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/lifecycle/binary.go 78.26% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5361   +/-   ##
=======================================
  Coverage   25.43%   25.43%           
=======================================
  Files         446      446           
  Lines       47839    47844    +5     
=======================================
+ Hits        12166    12168    +2     
- Misses      34721    34723    +2     
- Partials      952      953    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Warashi Warashi enabled auto-merge (squash) November 22, 2024 08:40
@Warashi Warashi merged commit b8070a9 into master Nov 22, 2024
18 checks passed
@Warashi Warashi deleted the pipedv1-plugin-lifecycle-manager-retry branch November 22, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants