Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kubernetes application configuration and deployment input structures #5356

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Nov 21, 2024

What this PR does:

  • add KubernetesApplicationSpec with minimal fields
  • decode the application config in the DetermineVersions method and pass values to manifest loader

Why we need it:

We have to load application config to treat the kubernetes resources.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…tructures

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 25.40%. Comparing base (669bbd2) to head (d258cdd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 12 Missing ⚠️
...pp/pipedv1/plugin/kubernetes/config/application.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5356      +/-   ##
==========================================
- Coverage   25.41%   25.40%   -0.01%     
==========================================
  Files         445      446       +1     
  Lines       47793    47807      +14     
==========================================
  Hits        12146    12146              
- Misses      34697    34711      +14     
  Partials      950      950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 16edf80 into master Nov 21, 2024
16 of 18 checks passed
@Warashi Warashi deleted the k8s-plugin-determine-versions-server branch November 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants