Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DetermineVersions of k8s plugin #5257

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Oct 7, 2024

What this PR does / why we need it:

This PR implements DetermineVersions of the Kubernetes plugin.
I have not implemented the manifest loader yet, so this gRPC implementation does not work now.
Please see the tests to see how this implementation works.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi changed the title Implement DetermineVersions Implement DetermineVersions of k8s plugin Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 75.80645% with 15 lines in your changes missing coverage. Please review.

Project coverage is 24.11%. Comparing base (d1f3d7e) to head (cc79d84).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5257      +/-   ##
==========================================
+ Coverage   24.04%   24.11%   +0.06%     
==========================================
  Files         439      441       +2     
  Lines       47021    47080      +59     
==========================================
+ Hits        11305    11352      +47     
- Misses      34813    34825      +12     
  Partials      903      903              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi marked this pull request as ready for review October 7, 2024 06:05
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Warashi Warashi enabled auto-merge (squash) October 8, 2024 02:31
@Warashi Warashi merged commit 3ce7977 into master Oct 8, 2024
17 checks passed
@Warashi Warashi deleted the k8s-plugin-load-manifests branch October 8, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants