-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic in ECS driftdetection when a taskdef in livestates does not exist #5240
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5240 +/- ##
==========================================
+ Coverage 22.92% 23.94% +1.01%
==========================================
Files 420 437 +17
Lines 45336 46997 +1661
==========================================
+ Hits 10392 11252 +860
- Misses 34147 34841 +694
- Partials 797 904 +107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
… exist (#5240) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
#5263 (#5265) * Fix panic in ECS driftdetection when a taskdef in livestates does not exist (#5240) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Upgrade aws-sdk-go-v2 (#5241) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * upgrade aws-sdk-go-v2 Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * upgrade aws-sdk-go-v2/**/* Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix compile errors caused by the breaking change Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix a test due to added RestartPolicy Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: avoid panic when live taskdef does not exist Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix go.sum by `make update/go-deps` Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Remove an unused field 'configFilePathInGitRepo' (#5248) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * remove unused field 'configFilePathInGitRepo' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Support fetching a piped config from AWS SSM Parameter Store (#5249) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add --aws-ssm-parameter Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add config-aws-ssm-parameter to piped Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs of runtime options Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Remove subnet ordering in head manifest (#5254) Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update quickstart header note (#5255) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update feature status (#5256) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Support directly designating a gitSSHKey instead of File for launcher (#5258) * Generate v0.49.x docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add --git-ssh-key-env Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs: add '--git-ssh-key-env' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add '\n' at the end of ssh key Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Directly use data instead of env Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Clarify the flag description Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix error message: 'and' -> 'or' Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add workflow steps to build and publish quickstart manifests (#5260) Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update workflow not to run by matrix (#5262) Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update RELEASE to v0.49.1 and update v0.49.x docs (#5263) * update RELEASE to v0.49.1 Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs of v0.49.x by `make release version=v0.49.1` Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Tetsuya Kikuchi <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: HoangNguyen689 <ndhoang.bk.hedspi@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
What this PR does / why we need it:
I added a nil check.
TaskDefs in livestates sometimes do not exist.
e.g. When a service is created but the taskset does not exist yet.
cf. LiveTask is set here:
pipecd/pkg/app/piped/livestatestore/ecs/store.go
Lines 66 to 99 in 1477e76
Which issue(s) this PR fixes:
N/A
Does this PR introduce a user-facing change?: