Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the rollbackStages to fix the flaky tests #5230

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 26, 2024

What this PR does / why we need it:

as title

Which issue(s) this PR fixes:

Fixes #5164

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi enabled auto-merge (squash) September 26, 2024 08:03
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.90%. Comparing base (c3386cf) to head (da75443).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5230      +/-   ##
==========================================
- Coverage   22.91%   22.90%   -0.01%     
==========================================
  Files         419      419              
  Lines       45321    45322       +1     
==========================================
- Hits        10385    10382       -3     
- Misses      34139    34142       +3     
- Partials      797      798       +1     
Flag Coverage Δ
22.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a test is flaky in pipedv1/controller/planner_test.go
3 participants