-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use make release
for major/minor releases
#5225
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5225 +/- ##
=======================================
Coverage 22.82% 22.83%
=======================================
Files 419 419
Lines 45304 45304
=======================================
+ Hits 10340 10344 +4
+ Misses 34169 34165 -4
Partials 795 795
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it:
Uses
make release
instead ofmake release/init
andmake release/docs
for major/minor releases.cf.
pipecd/Makefile
Lines 218 to 231 in 909fd76
Directly specifies to use
make release/init
for patch releases.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: