[Lambda] Support Drift Detection for Lambda #5186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5186 +/- ##
==========================================
- Coverage 22.93% 22.85% -0.09%
==========================================
Files 419 420 +1
Lines 44986 45247 +261
==========================================
+ Hits 10318 10340 +22
- Misses 33873 34111 +238
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. |
Warashi
reviewed
Sep 5, 2024
Comment on lines
263
to
276
| // sortMap sorts the given map by keys and returns a new map. | ||
| func sortMap(m map[string]string) map[string]string { | ||
| keys := make([]string, 0, len(m)) | ||
| for k := range m { | ||
| keys = append(keys, k) | ||
| } | ||
| slices.Sort(keys) | ||
|
|
||
| sorted := make(map[string]string) | ||
| for _, k := range keys { | ||
| sorted[k] = m[k] | ||
| } | ||
| return sorted | ||
| } |
There was a problem hiding this comment.
The for-range for map[string]string is always looped in random order.
So, this code may not work as expected.
There was a problem hiding this comment.
I understood, what a meaningless code... 😅
let me re-think...
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
|
@ffjlabo Would you please review again? This is the only one change: #5186 (comment) |
|
Sorry for the rough review🙏 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Supported DriftDetection for Lambda
When OutOfSync:
Restrictions:
sources3Buckets3Keys3ObjectVersionWhich issue(s) this PR fixes:
Fixes #5182
Does this PR introduce a user-facing change?: Users can see drifts.
Note:
To use this feature, users need to add the following IAM Actions to their Piped's IAM Role.
Later I'll describe the details in another PR.