Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add notes about drift detection #5120

Merged
merged 6 commits into from
Aug 19, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`. | No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a note and place under L57

This feature is automatically enabled for all applications.

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

Note: If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an easier to read flow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i fixed 7b6dba3


You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,6 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,6 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,6 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,6 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`.| No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`.| No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`.| No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`.| No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`.| No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ Note: By default, the sum of traffic is rounded to 100. If both `primary` and `c

| Field | Type | Description | Required |
|-|-|-|-|
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. | No |
| ignoreFields | []string | List of fields path in manifests, which its diff should be ignored. This is available for only `KubernetesApp`.| No |

## PipeCD rich defined types

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ This status means the application is deploying and the configuration drift detec

This feature is automatically enabled for all applications.

If you want to trigger deployment automatically when `OUT_OF_SYNC` occurs, see [Trigger configuration](./triggering-a-deployment/#trigger-configuration).

You can change the checking interval as well as [configure the notification](../../managing-piped/configuring-notifications/) for these events in `piped` configuration.

### Ignore drift detection for specific fields
Expand Down
Loading