Add notes of linking target groups and ELB listener rules in advance #5031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5031 +/- ##
=======================================
Coverage 22.44% 22.44%
=======================================
Files 520 520
Lines 56852 56852
=======================================
Hits 12762 12762
Misses 43063 43063
Partials 1027 1027 ☔ View full report in Codecov by Sentry. |
kumo-rn5s
pushed a commit
to kumo-rn5s/pipecd
that referenced
this pull request
Jul 11, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: kumo-rn5s <firosstuart@gmail.com>
khanhtc1202
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
This was referenced Jul 29, 2024
Merged
This was referenced Aug 13, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add notes that a user needs to link target groups and ELB listener rules in advance.
If not, a piped will not control traffic weights and a new taskset cannot receive traffic.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: no