Fix the docs for the script run feature status #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5018 +/- ##
==========================================
- Coverage 22.45% 22.44% -0.02%
==========================================
Files 520 520
Lines 56852 56852
==========================================
- Hits 12766 12760 -6
- Misses 43060 43066 +6
Partials 1026 1026 ☔ View full report in Codecov by Sentry. |
Merged
khanhtc1202
pushed a commit
that referenced
this pull request
Jul 12, 2024
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed the description of the script run feature.
Currently, we can use the script run stage without the rollback feature on all kinds of applications.
background
I implemented the script run stage without rollback feature In this PR #4720.
But later, I implemented the rollback feature for the k8s app: #4743.
Which issue(s) this PR fixes:
Part of #4643
Does this PR introduce a user-facing change?: