Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for SCRIPT_RUN stage #4734

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Add docs for SCRIPT_RUN stage #4734

merged 1 commit into from
Dec 25, 2023

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Dec 22, 2023

What this PR does / why we need it:

Documentation for SCRIPT_RUN stage

Which issue(s) this PR fixes:

Part of #4643

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02343e0) 30.83% compared to head (9e6ed79) 30.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4734   +/-   ##
=======================================
  Coverage   30.83%   30.83%           
=======================================
  Files         221      221           
  Lines       26015    26015           
=======================================
  Hits         8023     8023           
  Misses      17342    17342           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ffjlabo ffjlabo enabled auto-merge (squash) December 23, 2023 08:07
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🪨

@ffjlabo ffjlabo merged commit c14367c into master Dec 25, 2023
14 checks passed
@ffjlabo ffjlabo deleted the add-docs-for-script-run branch December 25, 2023 03:19
t-kikuc pushed a commit that referenced this pull request Dec 26, 2023
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
nnnkkk7 pushed a commit to nnnkkk7/pipecd that referenced this pull request Feb 1, 2024
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants