Add rfc custom stage #4203
Merged
Add rfc custom stage #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-namba
requested review from
nghialv,
khanhtc1202 and
knanao
as code owners
knanao
reviewed
Feb 21, 2023
khanhtc1202
reviewed
Feb 24, 2023
| Currently, users can use only stages that PipeCD have already defined. But some users want to define new stages by their use-cases as bellow. | ||
|
|
||
| - Deploying infrastructure by tools other than that PipeCD supports (terraform and kubernetes) such as SAM, cloud formation…. | ||
| - Running End to End tests |
There was a problem hiding this comment.
should not be listed here (CI roles)
There was a problem hiding this comment.
I think this can be included CD roles because there is some cases where developers want to check pods run.
khanhtc1202
reviewed
Feb 24, 2023
khanhtc1202
reviewed
Feb 24, 2023
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
khanhtc1202
approved these changes
Feb 28, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add RFC to implement custom stage
Which issue(s) this PR fixes:
Fixes #1089
Does this PR introduce a user-facing change?: