Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better way to get those 2 values instead of set it via service def. #2011

Closed
pipecd-bot opened this issue May 27, 2021 · 1 comment · Fixed by #2021
Closed

Find better way to get those 2 values instead of set it via service def. #2011

pipecd-bot opened this issue May 27, 2021 · 1 comment · Fixed by #2021

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/8808feb81ca5eafb6b84b585fb4701a0dbba5d9b/pkg/app/piped/cloudprovider/ecs/client.go#L149-L152

This was created by todo plugin since "TODO:" was found in 8808feb when #2007 was merged. cc: @khanhtc1202.
@khanhtc1202
Copy link
Member

khanhtc1202 commented May 27, 2021

I'm thinking about adding a new configuration field named TaskSetDefinitionFile which points to a file that contains those two fields: NetworkConfiguration and LaunchType. Besides, it's required to have LoadBalancer configuration to enable created Task serves traffic, thinking about adding that LoadBalancer configuration to this TaskSetDefinition too since it will be registered on TaskSet create.

The new .pipe.yaml will be

apiVersion: pipecd.dev/v1beta1
kind: ECSApp
spec:
  input:
    serviceDefinitionFile: path/to/servicedef.yaml
    taskDefinitionFile: path/to/taskdef.yaml
    taskSetDefinitionFile: path/to/taskset.yaml

and the TaskSetDefinition file content will be

launchType: FARGATE
networkConfiguration:
  awsvpcConfiguration:
    assignPublicIp: ENABLED
    subnets:
      - subnet-0285
      - subnet-0e74
loadBalancers:
  - targetGroupArn: xxx   # the production traffic serving target group
    containerName: sample-app
    containerPort: 80

pipecd-bot pushed a commit that referenced this issue May 28, 2021
…2021)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #2011 

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants