Skip to content

Commit

Permalink
Fix build and add TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Warashi committed Jul 3, 2024
1 parent 4b4ee33 commit e18305f
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions pkg/app/pipedv1/plugin/platform/kubernetes/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,11 @@ func (s *server) run(ctx context.Context, input cli.Input) (runErr error) {
// Start a gRPC server for handling external API requests.
{
var (
service = planner.NewPlannerService(input.Logger)
opts = []rpc.Option{
service = planner.NewPlannerService(
nil, // TODO: Inject the real secret decrypter. It should be a instance of pipedv1/plugin/secrets.Decrypter.
input.Logger,
)
opts = []rpc.Option{

Check warning on line 78 in pkg/app/pipedv1/plugin/platform/kubernetes/server.go

View check run for this annotation

Codecov / codecov/patch

pkg/app/pipedv1/plugin/platform/kubernetes/server.go#L74-L78

Added lines #L74 - L78 were not covered by tests
rpc.WithPort(s.apiPort),
rpc.WithGracePeriod(s.gracePeriod),
rpc.WithLogger(input.Logger),
Expand Down

0 comments on commit e18305f

Please sign in to comment.