Skip to content

Commit

Permalink
crypto: img-hash - remove need for error return variable ret
Browse files Browse the repository at this point in the history
The assignment to error return variable ret and then the jump to
an error exit path can be simplified by just returning the error
return at the failure point. This allows variable ret and the
error return path to be removed. This cleans up a static analysis
warninng that variable ret is being assigned (value never being
used) and being re-assigned later.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Colin Ian King authored and herbertx committed Sep 17, 2021
1 parent 29601c8 commit 5e91f56
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/crypto/img-hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -674,24 +674,19 @@ static int img_hash_digest(struct ahash_request *req)
static int img_hash_cra_init(struct crypto_tfm *tfm, const char *alg_name)
{
struct img_hash_ctx *ctx = crypto_tfm_ctx(tfm);
int err = -ENOMEM;

ctx->fallback = crypto_alloc_ahash(alg_name, 0,
CRYPTO_ALG_NEED_FALLBACK);
if (IS_ERR(ctx->fallback)) {
pr_err("img_hash: Could not load fallback driver.\n");
err = PTR_ERR(ctx->fallback);
goto err;
return PTR_ERR(ctx->fallback);
}
crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
sizeof(struct img_hash_request_ctx) +
crypto_ahash_reqsize(ctx->fallback) +
IMG_HASH_DMA_THRESHOLD);

return 0;

err:
return err;
}

static int img_hash_cra_md5_init(struct crypto_tfm *tfm)
Expand Down

0 comments on commit 5e91f56

Please sign in to comment.