Fix small errors, adjust orbitscanner balance #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The crew table was thrown away on start and new crew generated on accident - Only give the player enough crew on start to ensure they can take off from the station
- Increase scan resolution, decrease minimum altitude, increase aperture - Should result in faster data acquisition than the cheap scanner, even in high orbit with slower orbital speed
- Doesn't fully fix the UX related to expired items, but prevents an error
- Instead of switching to distance-to-center altitude, display distance to surface of target relative to target's sea level radius instead
|
Could you also squeeze in a commit for the Q/R keys change as default? |
|
Yes, will do that in the morning. Thanks for the reminder! |
Gliese852
reviewed
Feb 1, 2023
- Skipjack is intended to be a medium courier / exploration ship with additional sensor packages - Provide it some extra flexibility for scanners and sensors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5512, by refreshing the BBS if the player tries to click on a negative-time ad. A more in-depth fix will need to be deferred to the next patch.
Fixes #5511, prevents an erroneous overwrite of the CrewRoster table on game start. Also generates enough crew to take off with the starting ship, in case we or others setup a start with a ship requiring multiple crew members.
Fixes #5508, displays orbital distance relative to sea-level-radius of the body rather than body's surface. Provides a true "distance to surface" display.
Fixes #5521, increase Skipjack sensor slots to 3 to make it an "exploration" themed medium courier.
This PR also adjusts the parameters of the expensive orbital scanner to provide a generally faster scan rate than a cheap scanner, and make it a little bit more useful when scanning small-to-medium moons.