Add paintshop to stations #5342
Conversation
|
Nice! I'm thinking (as I always do), that this shouldn't be available on all stations. Maybe something with station size? Tech level? Homeworld? (The other tabs are sort of required to be there, because "Frontier" / "It's always been like that"). |
|
With the second commit the paintshop is quite more testable as in the initial state it didn't work at all. Now I need to probably separate the color changing thing to three separate colors (probably use sliders instead as well) and also not make it look horrible in terms of UI design |
|
One can now pick colors by hand, so I removed the color randomizer button without giving it much thought. Maybe I should've left it in. What do you think? |
|
Might be nice for those who are more just browsing, want to see ideas. |
Also satisfy clang format, hopefully
|
The current (placeholder) painting price algorithm is hullMass * 2.5 [10.0, 'varada'] Ideally, I think it should be more similar to: |
|
To avoid having two "ship" icons, perhaps using the "fountain_pen" icon would be better, in lieu of a paint sprayer for now. I once again suggest not having text that refers to the player as "sir" as the pilot (and player) may not be male. |
|
Ah, "sir" is only for males right? English is my secondary language - I will change that. I think I can just wait for the paint sprayer unless it takes months. |
|
I'll make one as soon as my school stuff winds down. Hopefully im the weekend the latest. |
|
Actually I thought of a better idea. Why not have the paintshop be part of the ShipRepair tab? If your ship is undamaged and the station meets the threshold of having the paintshop, then after the "Your ship is in perfect working condition" line there can be another -- potentially variable scripts: "We offer painting services. For your (shipname) we would charge $x. How about it?" / "Since you're here, how about we give your (shipname) a makeover? It'll cost you only $x." / "For $x we can customise your ship's paintjob." This would be followed by an "Enter paint shop" button. The user would not be charged at this point; the price is just mentioned up front. Some of the the greeting texts in the paintshop would be changed as the user has been greeted already, so lines could be like "Please use this tool to show us how you'd like it." / "What design would you like your ship to have?" Then the apply paint button can say, "Apply paintjob for $x" perhaps. This idea solves the problem of requiring an extra tab icon, and solves the mystery about who is talking to you about the paintjob, as it'd be assumed to be the station mechanic we see on the first part of the ShipRepair tab. |
|
If using a tab, as @Keeper1st suggests, we might want to consider also adding a line in the Lobby "This station rocks a paintshop" (but better worded), as else, people might not notice we even have paintshops in the game? Ship repair tab is not something I usually clicked when I played the game. |
|
That was my first thought as well. Having its separate tab aids discoverability a lot. |
|
@WKFO How about this one? |
Co-Authored-By: Szlrd <4182678+nozmajner@users.noreply.github.com>
|
@nozmajner Nice! |
|
If it's going to remain a separate tab, then I think A) the default tab icon size needs to change or they'd appear on top of some of the center tabs (I change the icon size in my own installation anyway as the default size is enormous) and B) there should be a facegen for the detailer. What would the title of the person be? "Ship Detailer" perhaps? Another no-icon possibility would be on stations which have a ship detailer (i.e. paintshop), it shows up on the bulletin board as So-and-so's Ship Detailing Service. But we have the icon now, so... If you're editing the icons file, how about a change to the Major Imports and Major Exports icons, so instead of only a slight change in size from the Minor versions, they also have two arrows or two arrow shafts, to make them a little more distinctive, suggesting visually a larger quantity of stuff coming or going? |
|
I'd prefer if paintjob was a separate thing, OR the repair tab be renamed so that people do not miss the fact that it has more things than just repair. |
|
Just installed this for the first time. It probably should tell the player up front that they don't have enough money rather than let them not realize they won't be able to pay for it. Perhaps the price should list as "Insufficient funds" in yellow to be consistent. Not sure I like it saying $0 until you make a change. If there were price variables as you changed more than one color, changed the design, or something, that would be cool, but as it's a flat fee I think it should list that up front always, and just not apply anything if you click Apply but haven't changed anything. I notice there's a duplicate "local pionillium = ui.fonts.pionillium" line in the 08-paintshop.lua also. |
|
The pricing thing is a remnant from the time when I thought of charging more for pattern changes (then discarded the idea). I will change that. Thanks for pointing out! |
|
@WKFO what's the status of this? You've done everything you wanted to do with this? Ready for merge? (I'd squash merge, I think, unless you want to clean up the commit history) |
|
No more edits are planned. I did everything I wanted. Should be ready. (Squash merge sounds fine.) |
|
Couple of bugs / usability issues I found playing around with the paintshop feature:
Finally, I'll second the requests for the paint shop to be moved to the Ship Repair tab, as there's really no reason to have a paint shop tab visible if the station doesn't support the paint shop, and it's fairly easy to add a line to the lobby or ship repairs tab letting players know the option is available. This isn't a hard requirement to merge the PR, but I think it's more semantically appropriate to be a subtab of the repair screen, and we are starting to have too many top-level tabs in the station view. |
|
Hmm, if it goes under the repair tab, then maybe I could update the icon, and the station could pick the wrench and driver icon when there's no paint shop, and could pick an icon that indicates that paint shop is available if it is. |
|
The tab icon would most likely be best served in the repair tab interface itself as a button to go to the paintjob options; the paintjob interface would fit most naturally as a "fullscreen modal" interface over top of / replacing the repair interface when activated, similar to e.g. the missions window.
A "we offer ship repair, maintenance, and cosmetic services at this location" could suffice I think - along with renaming the "repair" tab to "Ship Maintenance" or similar. |
|
I don't know what's the deal with the pattern selector. In my Pioneer, Pumpkinseed only has 1 pattern anyway. It can cylce through all 10 patterns for Sinonatrix without problem though. |
Adds paintshop to faction homeworld stations and some high population stations. There you can change the colors and the painting pattern of your ship. Pricing is calculated from the surface area approximated by adding up the cross section areas from all sides.
paintshopPreview.mp4