Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing shapekey from landing gear #5341

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Conversation

bszlrd
Copy link
Contributor

@bszlrd bszlrd commented Feb 10, 2022

@AMDmi3 gave a line about "Sphere_018-mesh" having an issue with assimp in #5339, then @Gliese852 found a "morph" tag. Which turned out to be a base shape shapekey left on the landing gear. I've removed it, hopefully it fixes #5339 and #5316

@bszlrd
Copy link
Contributor Author

bszlrd commented Feb 10, 2022

@AMDmi3 Could you test this?

@bszlrd
Copy link
Contributor Author

bszlrd commented Feb 10, 2022

Also I found the shapekey on the High LoD. And the med lod refuses to import to Blender, maybe that's the culprit, just the error message is wrong?
Edit: Gliese was able to pull out a proper one, let's hope these will fix the issue.

Co-Authored-By: Gliese852 <18342621+Gliese852@users.noreply.github.com>
@Bodasey
Copy link

Bodasey commented Feb 16, 2022

pure assimp3: (cf #5323)

Created shader skybox (address=0x8cd8490)
Created shader unlit (address=0x3614ce0)
CreateCollisionMesh for : (ac33)
CreateCollisionMesh for : (amphiesma)
CreateCollisionMesh for : (bluenose)
CreateCollisionMesh for : (bowfin)
CreateCollisionMesh for : (deneb)
CreateCollisionMesh for : (dsminer)
CreateCollisionMesh for : (kanara_civ)
CreateCollisionMesh for : (lodos)
CreateCollisionMesh for : (lunarshuttle)
CreateCollisionMesh for : (malabar)
CreateCollisionMesh for : (molamola)
CreateCollisionMesh for : (molaramsayi)
CreateCollisionMesh for : (natrix)
CreateCollisionMesh for : (nerodia)
CreateCollisionMesh for : (pumpkinseed)
CreateCollisionMesh for : (sinonatrix)
CreateCollisionMesh for : (skipjack)
CreateCollisionMesh for : (storeria)
CreateCollisionMesh for : (varada)
CreateCollisionMesh for : (vatakara)
CreateCollisionMesh for : (venturestar)
CreateCollisionMesh for : (wave)
models/ships/xylophis/xylophis_hi.dae:
Couldn't load file
Could not find model: xylophis
CreateCollisionMesh for : (error)

pure assimp5:

Created shader skybox (address=0x3084e30)
Created shader unlit (address=0x6e87150)
CreateCollisionMesh for : (ac33)
CreateCollisionMesh for : (amphiesma)
CreateCollisionMesh for : (bluenose)
CreateCollisionMesh for : (bowfin)
CreateCollisionMesh for : (deneb)
CreateCollisionMesh for : (dsminer)
CreateCollisionMesh for : (kanara_civ)
CreateCollisionMesh for : (lodos)
CreateCollisionMesh for : (lunarshuttle)
CreateCollisionMesh for : (malabar)
CreateCollisionMesh for : (molamola)
CreateCollisionMesh for : (molaramsayi)
CreateCollisionMesh for : (natrix)
CreateCollisionMesh for : (nerodia)
CreateCollisionMesh for : (pumpkinseed)
CreateCollisionMesh for : (sinonatrix)
CreateCollisionMesh for : (skipjack)
CreateCollisionMesh for : (storeria)
CreateCollisionMesh for : (varada)
CreateCollisionMesh for : (vatakara)
CreateCollisionMesh for : (venturestar)
CreateCollisionMesh for : (wave)
CreateCollisionMesh for : (xylophis)

Please note that

  • Deneb model has no graphical errors in both versions
  • the versions have been compiled in separate directories
  • I don't have a game developed enough to afford a Deneb ship and play/fly with it.

@AMDmi3
Copy link
Contributor

AMDmi3 commented Feb 16, 2022

@nozmajner yep, that fixes deneb, thank you!

@bszlrd
Copy link
Contributor Author

bszlrd commented Feb 16, 2022

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deneb model is broken
4 participants