Show import/export in commodity description in commodity market #5082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impaktor
force-pushed
the
commodity_market_show_import_export
branch
2 times, most recently
from
bc21dee to
c926ef6
Compare
Economy widget in system-econ-view.lua, shown in sector view, changed price alteration threshold for showing icon for minor import/export from +/- 2 to +/- 4. This changes space station (amount in stock), and what trader ships haul.
This should maybe be shown in a separate column, and could be placed better, but it's a start.
impaktor
force-pushed
the
commodity_market_show_import_export
branch
from
c926ef6 to
4c777d8
Compare
|
I think icons wouldn't look much out of place. |
|
@nozmajner, yeah, that could work. I assume we still want the text description as in the original (and your) screenshot. Both belt and suspenders! EDIT implementing that is outside the scope of my current ambition level as it's not quite as low hanging fruit as this was, and is left as an exercise to anyone wanting to have a crack at it. |
sturnclaw
approved these changes
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should maybe be shown in a separate column (but green/blue icons would look strange here?), and could be placed better,
but it's a start.
Open questions
It feels like the if-else statement to check if something is import/export keeps popping up everywhere (tradeship, spacestion, here, system econ view). Feels like there should be a method that gets that information for us somewhere?
At least which numbers for price modification should be the threshold for major/minor export import?