Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB related to allocation/free mismatch #4867

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix UB related to allocation/free mismatch #4867

merged 1 commit into from
Apr 27, 2020

Conversation

dodomorandi
Copy link
Contributor

Each buf contains an array of Colors, therefore the type of T in unique_ptr<T> must be Color[] instead of Color.

fluffyfreak
fluffyfreak approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@fluffyfreak fluffyfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, good catch, my mistake!

@fluffyfreak fluffyfreak merged commit a736e77 into pioneerspacesim:master Apr 27, 2020
@dodomorandi dodomorandi deleted the fix-gasgiant-ub branch April 27, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffyfreak fluffyfreak fluffyfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodomorandi @fluffyfreak