Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce hydrogen price back to 1 credit #4859

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Reduce hydrogen price back to 1 credit #4859

merged 1 commit into from
Apr 27, 2020

Conversation

WKFO
Copy link
Contributor

@WKFO WKFO commented Apr 16, 2020

̷R̷a̷i̷s̷i̷n̷g̷ ̷l̷o̷c̷a̷l̷ ̷d̷e̷l̷i̷v̷e̷r̷y̷ ̷r̷e̷w̷a̷r̷d̷s̷.̷
After countless protests across the galaxy, fuel prices are reduced again.

@WKFO WKFO marked this pull request as draft April 16, 2020 18:00
@WKFO WKFO marked this pull request as ready for review April 16, 2020 18:26
@WKFO WKFO changed the title Make local cargo runs profitable Make local cargo runs and package deliveries profitable Apr 16, 2020
@impaktor
Copy link
Member

Ah, yes, I've been planning to do this. In Frontier the rewards were typically:

  • Package delivery ~ 100-500 (no time limit)
  • Taxi missions ~ 1000-5000
  • Assassination ~ 7000-20,000

I'd like to see the actual rewards generated from these new levels. E.g. put each code snippet in a for loop and generate 1000 rewards for each, and show distribution for each (or mean/median/variance). (I have code for that, although it's trivial.)

but as you've pointed out (elsewhere), fuel cost is too high, as I've assumed using ~1t fuel per travel, i.e. ~10 credits in travel cost. The way I see it, fix is to either lower in-system fuel consumption e.g. 10 fold, or put fuel price (temporarily) back to 1 credit / tonne, until we've come up with something better.

@Zireael07
Copy link

I think the latter makes more sense, as I've pointed out elsewhere, hydrogen is the most abundant element in the universe. Even if it's processed somehow to become fuel, 10cr/tonne is too much.

@bszlrd
Copy link
Contributor

bszlrd commented Apr 17, 2020

@Zireael07 Yes, but storing Hydrogen is anything but trivial. It seeps trough the wall of tanks even in cryogenic form.

@Zireael07
Copy link

What year is Pioneer set in? Somewhere in 22nd century or even 23rd? I'm sure it's a solved problem by then, if it's widely used as fuel.

@WKFO
Copy link
Contributor Author

WKFO commented Apr 17, 2020

Pioneer is in 3200's.

@WKFO
Copy link
Contributor Author

WKFO commented Apr 21, 2020

So would you rather have this PR reduce the hydrogen price until we balance everything and re-implement the new economy, or...?

@Zireael07
Copy link

By reducing hydrogen price, you both make it more sensible from a point of view of a galaxy-spanning economy, AND don't have to change fuel consumption.

@impaktor
Copy link
Member

impaktor commented Apr 21, 2020

@WKFO yes. I think putting Hydrogen back to 1 credit, would again bring travel cost to ~10 credits per trip, which is what the trade is scaled for. And missions as well.

I'm not against hydrogen at 10 credits, but then either ship fuel consumption needs to go down, or trade and mission rewards need rebalancing, the latter of which seems to be the most work, which I'll gladly stay a way from.

@WKFO WKFO changed the title Make local cargo runs and package deliveries profitable Reduce hydrogen price back to 1 credit Apr 21, 2020
@WKFO
Copy link
Contributor Author

WKFO commented Apr 21, 2020

Makes my job a lot easier :)
Side note, trade is still broken because of #4858 even if hydrogen was free.

@WKFO
Copy link
Contributor Author

WKFO commented Apr 27, 2020

please review this, thanks

@fluffyfreak fluffyfreak merged commit 21c7ecf into pioneerspacesim:master Apr 27, 2020
@WKFO WKFO deleted the cargorun_fix branch May 7, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants