Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars that are brighter are now bigger and have a brighter color on the Starfield #4833

Merged
merged 8 commits into from
Mar 13, 2020

Conversation

tsoj
Copy link
Contributor

@tsoj tsoj commented Mar 11, 2020

To control the appearance there are new properties in data/config/Starfield.ini, I wrote some comments describing roughly what each parameter does. Here are three possible configurations:
screenshot1
screenshot2
screenshot3

@fluffyfreak
Copy link
Contributor

Nice work @tsoj

@tsoj
Copy link
Contributor Author

tsoj commented Mar 12, 2020

Ok, I noticed two issues that I need to solve first. When doing a hyperjump, the animation looks incredibly ugly. Also, after arriving at a system I needed to pause first and then resume to get the starfield filled properly. I just wanted to say why I closed this pull-request.

@tsoj tsoj closed this Mar 12, 2020
@fluffyfreak
Copy link
Contributor

@tsoj we don't close them for problems, just mark it as WIP in the title and added the WIP tag ;)
That way you can work on it, or it can be fixed by other people.

@fluffyfreak fluffyfreak reopened this Mar 12, 2020
@fluffyfreak fluffyfreak changed the title Stars that are brighter are now bigger and have a brighter color on the Starfield WIP - Stars that are brighter are now bigger and have a brighter color on the Starfield Mar 12, 2020
@sturnclaw
Copy link
Member

@tsoj I saw you dropped by IRC earlier today; if you're having issues with speaking in the channel, you'll need to authenticate with NickServ before you can talk on freenode due to the influx of spam across the entire IRC network in recent years.

@fluffyfreak fluffyfreak changed the title WIP - Stars that are brighter are now bigger and have a brighter color on the Starfield Stars that are brighter are now bigger and have a brighter color on the Starfield Mar 13, 2020
@fluffyfreak fluffyfreak removed the WIP label Mar 13, 2020
@fluffyfreak fluffyfreak merged commit 28df3c4 into pioneerspacesim:master Mar 13, 2020
@impaktor
Copy link
Member

Sorry, but this really should have been squash-merged. Now we have three commits that are just iterating settings in starfield. (I haven't looked at the other 5 commits, as it's amoot point now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants