Flying empty fix #3516
Merged
Flying empty fix #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -343,7 +343,8 @@ local onChat = function (form, ref, option) | |||
| form:SetMessage(howmuch) | |||
|
|
|||
| elseif option == 3 then | |||
| if Game.player.freeCapacity < ad.amount then | |||
| if (not ad.pickup and Game.player.freeCapacity < ad.amount) or | |||
| (ad.pickup and Game.player.totalCargo < ad.amount) then | |||
There was a problem hiding this comment.
No Game.player:GetEquipFree("cargo")?
There was a problem hiding this comment.
I don't know how to deal with #3450. Besides that I have messed up something with this PR.
…ckup cargo mission
robothauler
force-pushed
the
flying_empty_fix
branch
from
3f85d63 to
f8bd735
Compare
|
So this just needs a one line change to |
|
Bump! |
|
I would merge this as is. I think changing this will not work at the moment. I'm not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour that the player couldn't take a cargorun pickup mission if he hasn't enough free cargo space at the moment. laarmen advised me to use the equipment API but until the volume/mass thing is improved this PR seems to be the only practical solution IMHO.