fixup! reset selected system after hyperspace jump

Refactor the implementation so that the logic is handled inside the Lua
"onEnterSystem" callback instead.

Note we are still using the new "ResetSelectedSystem" instead of
"SetSystem" as the latter is not a public function. We could, instead,
change "SetSystem" to be public.

TODO: figure out a way to delay changing the map screen after a hyperspace
jump if the map is currently open.

data/pigui/views/map-sector-view.lua

@@ -472,7 +472,11 @@ end})
 Event.Register("onGameStart", onGameStart)
 Event.Register("onEnterSystem", function(ship)
 	hyperJumpPlanner.onEnterSystem(ship)
-	if ship:IsPlayer() then hyperspaceDetailsCache = {} end
+	if ship:IsPlayer() then
+		hyperspaceDetailsCache = {}
+		sectorView:ResetHyperspaceTarget()
+		sectorView:ResetSelectedSystem()
+	end
 end)
 
 -- reset cached data

src/Game.cpp

@@ -683,7 +683,6 @@ void Game::SwitchToNormalSpace()
 
 	m_player->EnterSystem();
 	RequestTimeAccel(TIMEACCEL_1X);
-	onSystemEntered.emit();
 }
 
 const float Game::s_timeAccelRates[] = {

src/Game.h

@@ -127,11 +127,6 @@ class Game {
 
 	GameLog *log;
 
-	/* Signals */
-
-	/** Emitted when exitting hyperspace into a system. */
-	sigc::signal<void()> onSystemEntered;
-
 private:
 	class Views {
 	public:

src/SectorView.cpp

@@ -181,12 +181,6 @@ void SectorView::SetDrawRouteLines(bool value)
 
 void SectorView::InitObject()
 {
-	// signal handlers
-	m_onSystemEntered = m_game.onSystemEntered.connect([&]() {
-			ResetHyperspaceTarget();
-			ResetSelectedSystem();
-		});
-
 	// single keystroke handlers
 	m_onToggleSelectionFollowView =
 		InputBindings.mapToggleSelectionFollowView->onPressed.connect([&]() {

src/SectorView.h

@@ -102,8 +102,6 @@ class SectorView : public PiGuiView, public DeleteEmitter {
 	float m_playerHyperspaceRange;
 	Uint8 m_detailBoxVisible;
 
-	ConnectionTicket m_onSystemEntered;
-
 	ConnectionTicket m_onToggleSelectionFollowView;
 	ConnectionTicket m_onWarpToCurrent;
 	ConnectionTicket m_onWarpToSelected;

src/lua/LuaSectorView.cpp

@@ -27,6 +27,7 @@ void LuaObject<SectorView>::RegisterClass()
 		.AddFunction("AddToRoute", &SectorView::AddToRoute)
 		.AddFunction("SwitchToPath", &SectorView::SwitchToPath)
 		.AddFunction("ResetView", &SectorView::ResetView)
+		.AddFunction("ResetSelectedSystem", &SectorView::ResetSelectedSystem)
 		.AddFunction("SetHyperspaceTarget", &SectorView::SetHyperspaceTarget)
 		.AddFunction("ResetHyperspaceTarget", &SectorView::ResetHyperspaceTarget)
 		.AddFunction("GetMap", [](lua_State *l, SectorView *sv) {