Additional testing and associated bug fixes related to H.265 payloader #287
+311
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DONL is increased by 2 the first time and 1 thereafter.
|
@kevmo314 @Sean-Der @lebedyncrs Can you please confirm that you have made the corrections associated with the test? |
y-kawawa
commented
Jan 7, 2025
| return | ||
| } | ||
|
|
||
| if len(nalu) <= int(mtu) { | ||
| naluLen := len(nalu) + 2 |
There was a problem hiding this comment.
To prevent the MTU size from being exceeded during aggregation packet, the size is compared by adding 2 bytes for the aggregation header.
|
|
||
| if aggregationBufferSize+marginalAggregationSize > int(mtu) { | ||
| flushBufferedNals() | ||
| marginalAggregationSize = calcMarginalAggregationSize(nalu) |
There was a problem hiding this comment.
After flushing, recalculate because the margin conditions change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#165 (comment)