Enable supported EC point formats and supported algorithm extensions #556
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 76.37% 76.73% +0.35%
==========================================
Files 95 95
Lines 5672 5677 +5
==========================================
+ Hits 4332 4356 +24
+ Misses 999 974 -25
- Partials 341 347 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| pointFormatCount := int(binary.BigEndian.Uint16(data[4:])) | ||
| if supportedGroupsHeaderSize+(pointFormatCount) > len(data) { | ||
| pointFormatCount := int(data[4]) | ||
| if supportedPointFormatsSize+pointFormatCount > len(data) { |
There was a problem hiding this comment.
This now adheres to the same way that we encode the supported EC point formats.
|
Could we add a test or two for this before we merge? |
|
@daenney sure thing -- this is being tested in the general case, which is why enabling these extensions started causing test failures. However, I think the unit tests could be improved... will do so ASAP. |
Enables parsing the elliptic curve supported points format extension. https://www.rfc-editor.org/rfc/rfc8422.html#section-5.1.2 Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Enables parsing the supported signature algorithms extension. https://datatracker.ietf.org/doc/html/rfc5246#autoid-39 Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Adds Daniel Mangum to AUTHORS.txt. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Fixes error in parsing supported elliptic curve point formats extension. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
Adds missing unmarshal unit tests for extensions that did not have them. These ensure that marshal / unmarshal is round-trippable. Signed-off-by: Daniel Mangum <georgedanielmangum@gmail.com>
hasheddan
force-pushed
the
feat/supported-points
branch
from
3ddcaba
to
fa7bdc0
Compare
Enables parsing the elliptic curve supported points format extension.
https://www.rfc-editor.org/rfc/rfc8422.html#section-5.1.2
Signed-off-by: Daniel Mangum georgedanielmangum@gmail.com
Enables parsing the supported signature algorithms extension.
https://datatracker.ietf.org/doc/html/rfc5246#autoid-39
Signed-off-by: Daniel Mangum georgedanielmangum@gmail.com