-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KeyLogWriter #344
Conversation
Fixes pion#343 - style is done in the same way as `tls.Config`.
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 75.84% 75.80% -0.05%
==========================================
Files 86 86
Lines 3660 3670 +10
==========================================
+ Hits 2776 2782 +6
- Misses 600 603 +3
- Partials 284 285 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This looks fantastic! Would be happy to take right away. Would you mind adding a test? Then should be good to go :) I can fix all the other little things (linters and so on) |
I'd like to see some actual tests for this. Since the KeyLogWriter is an |
It's hard to see at what level you wish to add tests for:
The latter being the most useful but also the most effort to write tests for. |
I am happy with 1/2! I think we can just remove randomness and then just assert a certain value is generated everytime. Just enough to make sure someone doesn't regress your work in the future :) |
Test was added a few weeks ago. |
The tests are fine, but as you can see from the PR status, our commit linter disagrees: https://github.com/pion/dtls/pull/344/checks?check_run_id=1838025192#step:3:15. It's a small thing, but we like to keep this consistent on this repo and everything else in the Pion org. Might be easiest to fold the test commit into the original one, that should make everything happy. |
Fixes #343 - style is done in the same way as
tls.Config
.Manually tested both as a client and as a server, then reading the resulting logs in Wireshark and confirming that data can be decrypted.