Always select matching CipherSuite #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the server selects a cipher suite that it supports, rather than the first that the client presents.
Add Carson Hoffman to the contributors list
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 71.08% 73.62% +2.53%
==========================================
Files 77 77
Lines 3534 3533 -1
==========================================
+ Hits 2512 2601 +89
+ Misses 756 654 -102
- Partials 266 278 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Yea amazing first PR :D |
|
Merged with ca3d982 just squashed into one commit. Amazing work @CarsonHoffman and thanks for the quick review @daenney :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the server checks to see if any of the client's cipher suites match any of its own, but always selects the first that the client offered. This can lead to a situation where the server selects a cipher suite it does not support; for example, if the client offers suites
[A, B]and the server supports only[B], the server will see the match ofB, but will then selectA, which it does not support.This PR makes the server always select a matching cipher suite, and adds a test to confirm this functionality;
HEADcurrently fails the test.