Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gave ScalingTransformation private properties and added equation to docstring #1455

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

MichaelClerx
Copy link
Member

Closes #1454.

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #1455 (d0a4972) into master (728d86f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1455   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         9300      9300           
=========================================
  Hits          9300      9300           
Impacted Files Coverage Δ
pints/_transformation.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MichaelClerx MichaelClerx requested a review from chonlei August 14, 2022 16:45
Copy link
Member

@chonlei chonlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes except the docstring bit which I think I've used p = x_model and q = x_search throughout in the transformation docstring. I think it'd better to string to that convention.

@MichaelClerx MichaelClerx requested a review from chonlei August 15, 2022 08:54
Copy link
Member

@chonlei chonlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MichaelClerx MichaelClerx merged commit 94d975a into master Aug 15, 2022
@MichaelClerx MichaelClerx deleted the 1454-scaling-trans branch August 15, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScalingTransformation has visible properties, could do with better docs
2 participants