Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.10 #1439

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Test on Python 3.10 #1439

merged 4 commits into from
Feb 23, 2022

Conversation

MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Feb 23, 2022

#1434

  • Now testing on Python 3.10
  • Updated rest of 3.9 tests to just use whatever the latest supported version is

@fcooper8472 @martinjrobins what do you think of the 2nd change? Is this a good idea in your opinion (the whole with block can be removed in that case, x64 is default too), or are we better off explicitly specifying the newest version we want to test on?

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1439 (f0276f2) into master (5b53eca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           90        90           
  Lines         8967      8971    +4     
=========================================
+ Hits          8967      8971    +4     
Impacted Files Coverage Δ
pints/_evaluation.py 100.00% <0.00%> (ø)
pints/_mcmc/_nuts.py 100.00% <0.00%> (ø)
pints/_transformation.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b53eca...f0276f2. Read the comment docs.

@MichaelClerx
Copy link
Member Author

MichaelClerx commented Feb 23, 2022

Only Python 3.11 to go now, and then we're on to Python 95!

@MichaelClerx
Copy link
Member Author

Python for workgroups

@fcooper8472
Copy link
Member

fcooper8472 commented Feb 23, 2022

@MichaelClerx omitting the specific version appears to default to 3.x which means >=3.0.0 <4.0.0 so I think we would lose certainty about which version specifically is being tested on. That doesn't necessarily matter...

The other thing is we should change all actions/setup-python@v1 to actions/setup-python@v2 as there have been numerous enhancements to that functionality since we originally wrote our GitHub actions scripts.

@MichaelClerx MichaelClerx merged commit 7142c9a into master Feb 23, 2022
@MichaelClerx MichaelClerx deleted the 1434-py310 branch February 23, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants