Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Python3.9 testing #1243

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Testing Python3.9 testing #1243

merged 4 commits into from
Jan 11, 2021

Conversation

MichaelClerx
Copy link
Member

See #1242

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1243 (0dfceeb) into master (a571e8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1243   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines         8730      8730           
=========================================
  Hits          8730      8730           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a571e8b...0dfceeb. Read the comment docs.

@fcooper8472
Copy link
Member

This looks fine.

We should also retire testing for 3.5, which has reached end of life. New ticket for that, or just add it to this change?

@MichaelClerx
Copy link
Member Author

Can we wait for it to break? I'm sure there's still voluntary and involuntary 3.5 users out there in the academic ecosystem

@fcooper8472
Copy link
Member

Yeah, that's definitely something that we can do. And that might be appropriate, if there are still systems out there without access to 3.6.

The opportunity cost is not getting to use new features such as f-strings, which will make PINTS code nicer. Not a huge deal, though.

Why did we drop 3.4?

@MichaelClerx
Copy link
Member Author

Good question!

We're still testing 2.7 so f strings are out anyway. But 3.4... I think we just couldn't be bothered to wait for more than 4 unit tests? Maybe we should add it back in now, since the github actions thing seems to be working fairly quickly?

@MichaelClerx
Copy link
Member Author

Error: Version 3.4 with arch x64 not found

Maybe that was why :D

@MichaelClerx
Copy link
Member Author

Psssst @fcooper8472 !

Copy link
Member

@fcooper8472 fcooper8472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MichaelClerx MichaelClerx merged commit 9dc9958 into master Jan 11, 2021
@MichaelClerx MichaelClerx deleted the 1242-python39 branch January 11, 2021 14:20
@MichaelClerx
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants