-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Python3.9 testing #1243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1243 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 83 83
Lines 8730 8730
=========================================
Hits 8730 8730 Continue to review full report at Codecov.
|
This looks fine. We should also retire testing for 3.5, which has reached end of life. New ticket for that, or just add it to this change? |
Can we wait for it to break? I'm sure there's still voluntary and involuntary 3.5 users out there in the academic ecosystem |
Yeah, that's definitely something that we can do. And that might be appropriate, if there are still systems out there without access to 3.6. The opportunity cost is not getting to use new features such as f-strings, which will make PINTS code nicer. Not a huge deal, though. Why did we drop 3.4? |
Good question! We're still testing 2.7 so f strings are out anyway. But 3.4... I think we just couldn't be bothered to wait for more than 4 unit tests? Maybe we should add it back in now, since the github actions thing seems to be working fairly quickly? |
Maybe that was why :D |
Psssst @fcooper8472 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks! |
See #1242