1210 truncated normal

[rccreswell]

Adds the truncated normal distribution as a prior, for #1210

[codecov]

Codecov Report

Merging #1213 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines         8654      8681   +27     
=========================================
+ Hits          8654      8681   +27     

Impacted Files	Coverage Δ
pints/__init__.py	100.00% <ø> (ø)
pints/_log_priors.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dca9e0e...964d781. Read the comment docs.

[ben18785]

@rcw5890 Great job -- a first for me but I have no critical feedback. Good to go for me!

[ben18785]

@MichaelClerx Can you have a look? I'm happy for this to go in.

[MichaelClerx]

"Convert prior samples to be uniform within unit cube" --> Converting

(Sorry, just noticed that's not actually you!)

[MichaelClerx]

Since the NormalLogPrior is deprecated in favour of Gaussian, should this be a TruncatedGaussianLogPrior ?

[MichaelClerx]

I remember @fcooper8472 did some work on ensuring the log priors behaved in a consistent and well-defined way at discontinuous boundary points, and were tested for that. Is this consistent with that work?

[fcooper8472]

Looks good to me!

[ben18785]

Happy with either truncated normal or truncated Gaussian (admit the last one is more consistent but I slightly regret deprecating the normal word -- this was my silly decision, I think).

[MichaelClerx]

We could merge it and open another ticket to discuss the naming? As long as it's fixed before the next release I'm happy.

Code looks great!

[rccreswell]

I just made two small changes: fixing that other heading in the log priors notebook, and adding a test for inputs at the boundary

[ben18785]

@rcw5890 Looks great! Merging.