Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HalfCauchy.sample returns (n,1) array #1196

Merged
merged 2 commits into from
Aug 19, 2020
Merged

HalfCauchy.sample returns (n,1) array #1196

merged 2 commits into from
Aug 19, 2020

Conversation

DavAug
Copy link
Member

@DavAug DavAug commented Aug 19, 2020

See #1192 .

@DavAug DavAug requested review from MichaelClerx and chonlei August 19, 2020 08:32
@codecov
Copy link

codecov bot commented Aug 19, 2020 •
edited
Loading

Codecov Report

Merging #1196 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines         7796      7797    +1     
=========================================
+ Hits          7796      7797    +1
Impacted Files Coverage Δ
pints/_log_priors.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e28d0...d7dbcca. Read the comment docs.

chonlei
chonlei approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@chonlei chonlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

ben18785
ben18785 approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@ben18785 ben18785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @DavAug !

@ben18785 ben18785 merged commit 2b1576b into master Aug 19, 2020
@DavAug DavAug deleted the i1192-bug-composed-log-prior branch August 19, 2020 11:39
@chonlei chonlei mentioned this pull request Aug 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben18785 ben18785 ben18785 approved these changes

@chonlei chonlei chonlei approved these changes

@MichaelClerx MichaelClerx Awaiting requested review from MichaelClerx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavAug @ben18785 @chonlei