-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDecimate - want to be able to see on the screen when specify a large cycle #43
Comments
Could you give me a full script and the used parameters and probably the video you are using it on? I'm not too familiar with the usage, I always like a ready to reproduce scenario, thanks. |
Any video can be reproduced.
With a Japanese TV broadcast source (1440x1080), the maximum frame length is 600 frames, which is the limit of what can be seen on the screen display.
Even when large numbers are specified, such as cycleR=7779,cycle=38895, For example, |
I see. The freeze is just an unexpected side effect. |
Yep, for 1440x1080 even |
Whether it freezes or not is not the purpose of this issue. |
Thank you for your suggestion. |
Oh, I see, so the parameter is not for the positioning, but rather for specifing the frames displayed around the current frame. it makes sense now. One more question if I understand your idea correctly: the paging would always start at 0, 250, 500, etc (at multiples of |
Okay, I did not think of the idea of always displaying the list around the frame that is currently displayed. |
As an additional idea, it would be helpful to have the number of frames actually decimated within the range displayed by the |
Try this test build, please. Setting displayDecimation to other than 0 will display only frame info within the grouping range. |
Thank you very much! |
It is not the same as the original, but it would be just as easy to see if the column ended with a 9. |
Actually that was a bug, a regression when I rewrote the screen display part. I noticed that the last value appeared at the beginning of the next column, and the first line of the FILM:... space separated values was repeated as well. Then I checked the original 1.05 version, and it work without duplicating, so I fixed that part. |
Ah, it was a bug... I would appreciate it if you would consider my two requests. |
Displaying the actual number of decimations within the frame range must be easy I think. |
You are right. |
I have come up with a way to make it easier to find the cycles without changing the fold position of the listings. Proposal 1:Display the interval of decimation as a numerical value. Example display)
The number to be displayed can be either the number of frames counted from the front or the number of frames in between. Proposal 2:Specify the interval of decimation as a parameter in advance, and use a symbol to indicate how large or small the interval is compared to the number of frames. Parameter example Example of display
If the number of decimations is less than "5" set in the parameter, "-" is displayed; if the number is greater, "+" is displayed. If neither of the above is adopted, please implement only the idea of displaying the actual number of decimations within the range of displayDecimation and make it an official release. |
I see, this is a busy week but it's not forgotten. So the columns are not of the same widths, they are adaptive to the maximum length displayed in that columns. There is some freedom in it. |
I understand that as a display specification, either is fine. I thought of other ways to make it easier to find cycles, but could only come up with ideas for further additions.
yyy/xxxx/zzzzz yyy...Number of decimations within the current displayDecimation range
|
Regarding "1. display the cumulative..." could you please edit a theoretically expected screenshot from the above "example of display"? |
This is not a screenshot, but this is what it would look like.
xx: Number of decimations in the current list |
There was a slight error.
The left side of the parentheses is "yyyy" and the right side is the remaining value after subtracting "yyyy" from "zzzzz". |
Oh, it's handwritten... The first one was correct...
|
Check this one, please |
Oooh! It works exactly as I imagined it would! How about a proposal to make it easier to find a cycle changes in the list? |
Single space, yes. You have eyes like a hawk. |
dysplayOpt! Operation confirmed. How about this explanation of the options? displayDecimation - If more than zero then starting at the first value specified in Cycle, frames are displayed in a list of frames for the value specified in displayDecimation. e.g. displayDecimation = 250
If the Cycle range crosses within the range specified by displayDecimation, the pages are displayed separately.(Page means that the listings are displayed separately.) e.g. CycleR=20,Cycle=100,displayDecimation = 40
When this parameter is enabled, "#ofDecimations" is displayed.
This parameter is useful for large cycles, when the screen area is not enough to display all data within the range. default: 0 (int) I think the description of displayOpt is fine. |
Oh, I thought it would be a good idea to mention to Changelog that have fixed the list wrap bug. |
Two requests about displayOpt.
|
1.) |
1.) Those symbols looks good.
Use your judgment and adopt the one with the best visibility, please. 2.) I understood that it is not possible to display a symbol at a distance from the last decimation of the previous range of the current range. |
Some other variants (x64 versions) |
Wow! Thanks for the quick response! 4 >= 1 > 3 > 2 1 and 4 are hard to choose between, but I felt that 4 is easier to quickly understand than 1 because of the variation in the size of the letters. |
Ignore the <-,<>,-> in the post above. Hmmm, I am confused. |
I have compared them for a while and the visibility of 1 seems to be the best. One thing I noticed is that in the first list, "#ofDecimations x(y:z)" seems to show "x" with one less number. "y" is correct. The following is an additional explanation of displayOpt in "TDecimate - READ ME.txt". This display starts from the first frame drop in the current list, and the first frame drop is always indicated by "**", no matter where it is located. |
O.K. Then let it be *- or ** or *+ ? I liked #4 (<- ** +>) for the first sight but didn't test them, just had a quick look at it.
Yep, I missed it, done. |
I should have stated it clearly.
Thanks for the correction! |
I also liked variant4 at first, but on a screen scaled down to 1280x720, it was easier to find one ">>" than to find one "+>" out of 33 "**". |
New build with << and >> and fixed diff-by-one |
Thank you, it is perfect for me. |
I really like and use this modified version. I noticed while using a large Cycle, the first frame drop symbol in the list you corrected last time, but I am reporting that in some cases, a symbol that is not "**" is displayed. ◆Cases I have confirmed Case 1. Where it started to occur Case 2. Where it started to occur Case 3. Where it started to occur The above is just one example I have confirmed. If you have difficulty correcting this event, I would be happy to have you revert to the test3(TIVTC_dev_v1.0.28test3.7z) state.(I thought it was a matter of familiarity.) |
Thanks for the feedback, I'm looking into it. |
Ah, that's what you mean! I completely understand! The only other thing is that there is only one space between "userframe:" and "displayDecimation:". |
I have confirmed that it has been released and will close this issue. |
Since you implemented my request, I was also motivated to create a guide for IVTC from 29.97fps to 25fps utilizing TDecimate. https://ikotas.github.io/25fpsIVTCGuide/ There is only a Japanese version, but I think the translation of Chrome is quite good these days, so I hope it won't be a problem to understand the meaning. I was actually going to submit this guide to doom9, but since I just couldn't get the Activation email and had no way to contact the administrator, I gave up for now.... In addition, I apologize if such a post is against the rules. |
Thank you for the contribution, I'm sure it will be useful to many. |
Thank you for posting your share on doom9. I will tell you what I noticed. |
In TDecimate, if specify very large numbers for cycleR and cycle (ex. cycleR=7779,cycle=38895), cannot see the result on the screen.
(To begin with, setting display=true in this case will force AvsPmod to close.)
Is it possible to split the result display on the screen only, while leaving the cycleR and cycle specifications as they are?
For example, even if cycleR=7779,cycle=38895 is specified, if the screen display can show 250 frames at a time, etc., can check and make progress.
The text was updated successfully, but these errors were encountered: