Only log State transition result when state changes (#1753)

This log line is about 60% of total worker log volume. For most of the time, this line is not very helpful unless there is a change.
pinterest · Nov 15, 2024 · 09298a8 · 09298a8
1 parent fd2bbcf
commit 09298a8
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/deploy-service/common/src/main/java/com/pinterest/deployservice/handler/CommonHandler.java b/deploy-service/common/src/main/java/com/pinterest/deployservice/handler/CommonHandler.java
@@ -374,10 +374,12 @@ void transition(DeployBean deployBean, DeployBean newDeployBean, EnvironBean env
                 }
             }
             newDeployBean.setState(DeployState.SUCCEEDING);
-            LOG.info(
-                    "Set deploy {} as SUCCEEDING since {} agents are succeeded.",
-                    deployId,
-                    succeeded);
+            if (!DeployState.SUCCEEDING.equals(oldState)) {
+                LOG.info(
+                        "Set deploy {} as SUCCEEDING since {} agents are succeeded.",
+                        deployId,
+                        succeeded);
+            }
             return;
         }