Fix support newbytes from future #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously python2 code using python-future to backport the py3 bytes
behavior would trigger the following exception:
code:
from builtins import bytes as newbytes
from pymemcache.client.base import Client
client = Client(('localhost', 11211))
client.set(newbytes('key'), 'value')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/site-packages/pymemcache/client/base.py", line 297, in set
return self._store_cmd(b'set', key, expire, noreply, value)
File "/usr/local/lib/python2.7/site-packages/pymemcache/client/base.py", line 770, in _store_cmd
key = self.check_key(key)
File "/usr/local/lib/python2.7/site-packages/pymemcache/client/base.py", line 251, in check_key
key_prefix=self.key_prefix)
File "/usr/local/lib/python2.7/site-packages/pymemcache/client/base.py", line 91, in _check_key
key = key.encode('ascii')
File "/usr/local/lib/python2.7/site-packages/future/types/newbytes.py", line 381, in __getattribute__
raise AttributeError("encode method has been disabled in newbytes")
AttributeError: encode method has been disabled in newbytes
Add a test case for this and fix.
nichochar
approved these changes
Sep 7, 2018
| @@ -48,7 +48,10 @@ def get(self, key, default=None): | |||
| raise MemcacheIllegalInputError(key) | |||
| if isinstance(key, six.string_types): | |||
| try: | |||
| key = key.encode('ascii') | |||
| if isinstance(key, bytes): | |||
| key = key.decode().encode('ascii') | |||
There was a problem hiding this comment.
Out of curiosity, do we think there is a performance impact to the decode and rencoding? Intuitively it seems negligeable
jparise
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously python2 code using python-future to backport the py3 bytes
behavior would trigger the following exception:
code:
Output:
Add a test case for this and fix.