[BUGFIX] Critical! String Encoding Bugfix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ertedSet for the NSCharacterSet to fix this issue
|
You can access a private method in tests by creating an interface for it in the tests file. |
|
done 👍 |
|
Thanks for fixing this! I would have thought our disk caching tests would have caught this, but they weren't checking for URLs :( Thank you! |
garrettmoon
added a commit
that referenced
this pull request
Nov 19, 2015
[BUGFIX] Critical! String Encoding Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #41 I created a bugfix for #36
Maybe this should be unit tested, because it broke the complete DiskCache 😭. I prepared a test for this but cannot access the private method!