Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling in Xcode 12.0b4 #273

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

zacwest
Copy link
Contributor

@zacwest zacwest commented Aug 4, 2020

This beta added a diagnostic for passing more specific types to id-typed values:

Fixed type checking for block parameters using id with protocols. The compiler now emits an error for method calls with a block that uses parameters more specific than arguments with which it will be called. (57980961)

This beta added a diagnostic for passing more specific types to `id`-typed values:

> Fixed type checking for block parameters using id with protocols. The compiler now emits an error for method calls with a block that uses parameters more specific than arguments with which it will be called. (57980961)
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the fix, greatly appreciated!

@garrettmoon garrettmoon merged commit 10b3c3c into pinterest:master Aug 4, 2020
@mycroftcanner
Copy link

mycroftcanner commented Aug 8, 2020

PINRemoteImage doesn't compile as well @garrettmoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants