Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#trivial Fix #226 #246

Merged
merged 3 commits into from
Jun 10, 2019
Merged

#trivial Fix #226 #246

merged 3 commits into from
Jun 10, 2019

Conversation

garrettmoon
Copy link
Collaborator

No description provided.

@garrettmoon garrettmoon changed the title Fix #226 #trivial Fix #226 Jun 10, 2019
bolsinga
bolsinga approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@bolsinga bolsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool to add a test.

@ghost
Copy link

ghost commented Jun 10, 2019

🚫 CI failed with log

@garrettmoon garrettmoon merged commit 994c021 into master Jun 10, 2019
@garrettmoon garrettmoon mentioned this pull request Jun 10, 2019
Closed
@wiseoldduck
Copy link
Contributor

Unfortunately using the ttl cache incurs some measurable performance costs, that would be proportionally more severe for the memory cache. It's also less relevant (as the memory cache is already TTL = The process lifetime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolsinga bolsinga bolsinga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettmoon @wiseoldduck @bolsinga