Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support sudo & SSH connection options #14

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

cmacrae
Copy link
Contributor

@cmacrae cmacrae commented Jan 4, 2023

These changes (based on @arouzing's initial work, thank you!) introduce
configuration options for SSH connections and add support for using sudo.

Tested thoroughly on several systems and works as expected :)
I also fixed a bug on initial deploys by adding the --mkpath arg to rsync, otherwise systems fail to deploy on initial attempt.

@pinpox
Copy link
Owner

pinpox commented Jan 4, 2023

Hey @cmacrae, thanks a ton for this PR!

I reviewed the code and it looks good, just one question: I see you have removed the set -o pipefail -e; in https://github.com/pinpox/lollypops/pull/14/files#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0R101-R125
Those where necessary to stop deployment if any error occurs. Without those the execution will continue on error, which I think is a bad idea. Have you found a better solution?

I know it's a bit repetitive to add that to every SSH command, but there is not a way to add it in general (yet), see more about it here

@cmacrae
Copy link
Contributor Author

cmacrae commented Jan 4, 2023

You're very welcome! Thanks for sharing this awesome tool ✨
Ah, whoops! That was unintentional. I'll add them back shortly after I've finished my work day :)

These changes (based on @arouzing's initial work, thank you!) introduce
configuration options for SSH connections and add support for using sudo.
@cmacrae cmacrae force-pushed the feat/ssh_and_sudo_configuration branch from 25cba44 to 05ed7ba Compare January 4, 2023 18:50
@cmacrae
Copy link
Contributor Author

cmacrae commented Jan 4, 2023

There we go, added back in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants